Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add product icon theme #92268

Merged
merged 9 commits into from
Mar 9, 2020
Merged

Add product icon theme #92268

merged 9 commits into from
Mar 9, 2020

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Mar 9, 2020

For #79130

  • adds a new setting "workbench.productIconTheme"
  • adds a new contribution point productIconThemes,
  • JSON schema for product icon themes associated to -product-icon-theme.json

@aeschli aeschli self-assigned this Mar 9, 2020
@aeschli aeschli added this to the March 2020 milestone Mar 9, 2020
@aeschli aeschli merged commit dee6361 into master Mar 9, 2020
@aeschli aeschli deleted the aeschli/productIconsTheme branch March 9, 2020 14:44
@aeschli
Copy link
Contributor Author

aeschli commented Mar 9, 2020

@misolori FYI. The product icon theme allows to contribute a new font and overwrite the codicon icons with a new icon.
Next steps for which I need your help:

  • cleaning up and improve on the codicon names to describe the purpuse of the icon. E.g. instead of chevron-right, it should something like folded, or even editorGutter.foldMarker

@aeschli aeschli linked an issue Mar 16, 2020 that may be closed by this pull request
[themes] Add product icon themes #92791
Closed
14 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.

[themes] Add product icon themes
1 participant
@aeschli