OpenerService supporting URI and URL #84812

jrieken · 2019-11-14T11:44:26Z

This PR is for #83645.

IOpenerService and its contributions should support URI and ~~URL~~ plain strings
adopt editor link detection (Uri#parse can break path-component #45515)
adopt terminal link detection (Terminal URI auto decode #74604)
adopt markdown hover > 🙅‍♂ tricky because we use URIs for transformation
~~check other callers of IOpenerService.open or drive it via incoming issues~~ tackle this case by case
API openExternal which already accepts a string... (no API change yet)

This reverts commit e24fefe.

…e API as is

… keep the API as is" This reverts commit 544b0ab.

jrieken added 11 commits November 14, 2019 09:34

add URI.from(url)-overload

e24fefe

IOpener must accept URI and URL

9106843

IOpenerService#open accepts URI and URL

3816ecf

editor link detector uses URL

d891b0d

validator must support URI and URL, also extract utils for re-use

1603d3e

Merge branch 'master' into joh/opener

6e0019f

terminal link handler using URL, #74604

65159d0

use string instead of URL, help with IE11 and with unwanted URL magic

481485b

use string in markdown rendering - in most cases

953cd2e

simpler markdown link handling

7059739

openExternal uses resolver for URI and string

67ac711

rebornix assigned jrieken Nov 14, 2019

jrieken added 5 commits November 15, 2019 09:28

Revert "add URI.from(url)-overload"

0083c78

This reverts commit e24fefe.

extract openers

f651cca

allow $openUri to accept a URI and string, adopt consumer but keep th…

544b0ab

…e API as is

Revert "allow $openUri to accept a URI and string, adopt consumer but…

e51ef85

… keep the API as is" This reverts commit 544b0ab.

allow $openUri to accept URI and string

e80c62b

jrieken merged commit 261ef3e into master Nov 15, 2019

jrieken deleted the joh/opener branch November 15, 2019 14:31

Tyriar added this to the November 2019 milestone Nov 15, 2019

github-actions bot locked and limited conversation to collaborators Mar 27, 2020

Provide feedback