Code

Rework Uri.parse and Uri.toString#83060

Code

Merged

jrieken merged 23 commits intomastermicrosoft/vscode:masterfrom joh/uri-parsemicrosoft/vscode:joh/uri-parseCopy head branch name to clipboardOct 24, 2019

+642-305

Commits

Commits on Oct 22, 2019

• custom encode/decode logic

  jrieken

  committed
  359c17a

• keep input (for toString) when using URI.parse, URI.file uses now URI.parse

  Show description for 3e0ded9
  jrieken

  committed
  3e0ded9

• tweak test for less encoding, restore URI.toString(true) behaviour, escape backslash in non-windows cases

  jrieken

  committed
  40e3b80

Commits on Oct 23, 2019

• Merge branch 'master' into joh/uri-parse

  jrieken

  authored
  2166211

• adjust tests that relied on URI.toJSON or URI.toString output

  jrieken

  committed
  a7c1ece

• polish

  jrieken

  committed
  bea884b

• add tests that compare URI against nodejs/standard URL

  jrieken

  committed
  96aee26

• fix missing #-encode in URI.file factory

  jrieken

  committed
  612fdf5

• tweak tests, make sure nodejs tests are platform aware

  jrieken

  committed
  50d97cf

• more tests, check more sample against standard url, make sure we normalize well

  jrieken

  committed
  cc7fdb6

• tweak nodejs compare tests so that they work on windows

  jrieken

  committed
  989f98a

• cache regular expression, inline string constants

  jrieken

  committed
  59cd7f5

• fix drive letter regexp issue

  jrieken

  committed
  6f59bbd

• more test tweak...

  jrieken

  committed
  94d6dfd

• and more tweaks...

  jrieken

  committed
  11e2013

Commits on Oct 24, 2019

• Merge branch 'master' into joh/uri-parse

  jrieken

  authored
  5569584

• node nodejs specific test tweaks

  jrieken

  committed
  67c8c94

• polish, extract util functions, fix issue with overeager hex detection

  jrieken

  committed
  bbb516c

• some more test utils

  jrieken

  committed
  e0617e5

• add tests from old bugs that have been resolved "as designed"

  jrieken

  committed
  666ad41

• don't warn when fixing missing scheme, just do it... bring back strict mode for parse

  jrieken

  committed
  175ab4a

• remove encodeURI(uri.toString(true)) workarounds

  jrieken

  committed
  92292f4

• fix test failure after more strict parse in markdown convert

  jrieken

  committed
  10fe086