Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove executable bits from non-executable files #82103

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Remove executable bits from non-executable files #82103

merged 2 commits into from
Oct 10, 2019

Conversation

nikeee
Copy link
Contributor

@nikeee nikeee commented Oct 8, 2019

Some files had the executable bit set. This leads to debian package linting errors as mentioned in #20380. This issue does not fix all of these linting issues, but addresses some of them.

@Tyriar Tyriar assigned Tyriar and unassigned joaomoreno Oct 9, 2019
@Tyriar Tyriar added this to the October 2019 milestone Oct 9, 2019
@joaomoreno joaomoreno self-requested a review October 10, 2019 06:22
joaomoreno
joaomoreno approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@Tyriar Tyriar merged commit 1dd67cb into microsoft:master Oct 10, 2019
@nikeee nikeee deleted the fix-executable-bits branch October 10, 2019 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@nikeee @joaomoreno @Tyriar