Add icon font and adopt in panel area #81018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@misolori good stuff. I think we need to revisit our animation when clicking an action though, it feels a lot less smooth:
As for the changes: we always have to keep in mind that we need to support both icon font and SVG icon for the action bar because extensions will still continue to use SVG. PS: I would maybe not say |
bpasero
approved these changes
Sep 17, 2019
This was referenced Sep 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of #78889 and adds an icon font for all of our icons. I also began to adopt this in the panel area as that was the easiest place to start, will continue to adopt in the rest of the other areas.
I also added a new color token,
icon.default, that controls the default color. We'll likely add more colors when I get to those icons, this one covers most of our cases and is enough to get started.FYI: I'm submitting this work in smaller pieces so we don't end up with a massive PR.