Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yu Gothic UI to font-family jp #79735

Merged
merged 5 commits into from
Sep 18, 2019
Merged

Conversation

harujii
Copy link
Contributor

@harujii harujii commented Aug 24, 2019

Fix #79579
Prioritize Yu Gothic UI over Meiryo.

@msftclas
Copy link

msftclas commented Aug 24, 2019

CLA assistant check
All CLA requirements met.

@bpasero bpasero added this to the September 2019 milestone Aug 24, 2019
@bpasero bpasero requested a review from octref August 24, 2019 15:21
Copy link
Contributor

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be Yu Gothic, not Yu Gothic UI, which has the condensed kana:

Yu Gothic:

image

Yu Gothic UI:

image

But I just checked, currently for lang="ja", we are falling back to Yu Gothic on Windows 10, which is Chrome's default choice for Japanese characters. Here's stable:

image

@harujii
Copy link
Contributor Author

harujii commented Aug 28, 2019

@octref
Yu Gothic is not suitable for UI text and not familiar to Japanese as a UI font.
Is there any reason why vscode don't use the condenced font?

The reason to falling back to Yu Gothic is that probably don't have Meirio installed on your PC.
Meiryo is supplemental font for japanese.
To use it, install the Japanese language pack on your PC.
see also: https://docs.microsoft.com/en-us/typography/fonts/windows_10_font_list

@octref
Copy link
Contributor

octref commented Aug 28, 2019

Is there any reason why vscode don't use the condenced font?

I don't know. It has been there forever. If there's a good reason we can probably change it.

The reason to falling back to Yu Gothic is that probably don't have Meirio installed on your PC.
Meiryo is supplemental font for japanese.

Thanks! I feel our Japanese font stack should be consistent, either all using the UI condensed kana versions, or all using the wide normal versions. I have reached out to a few Japanese users to gather feedback. This would be a very drastic change to Japanese users so we need to be more careful.

@bpasero bpasero modified the milestones: September 2019, On Deck Aug 28, 2019
@bpasero
Copy link
Member

bpasero commented Aug 28, 2019

@octref thanks for doing that, let's wait for more feedback.

@octref
Copy link
Contributor

octref commented Sep 5, 2019

A bit more testing:

Win 10 defaults to Yu Gothic UI (narrow):

win-jp

macOS defaults to Hiragino Kaku Gothic ProN (wide):

mac-jp

Anyway, I throw out a Twitter poll for 7 days:

https://twitter.com/octref/status/1169661657900961792

image

@octref
Copy link
Contributor

octref commented Sep 9, 2019

The feedback so far heavily leans towards the narrower one.
@harujii I'd be fine if you also make Meiryo -> Meiryo UI change.

This should only affect Windows Japanese users.

@bpasero bpasero assigned octref and unassigned bpasero Sep 10, 2019
@bpasero
Copy link
Member

bpasero commented Sep 10, 2019

@octref feel free to merge when you feel like it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Japanese GUI font-family
4 participants