Strikeout deprecated CompletionItems

src/vs/editor/common/model/intervalTree.ts

@@ -18,7 +18,7 @@ export const enum ClassName {
 	EditorErrorDecoration = 'squiggly-error',
 	EditorUnnecessaryDecoration = 'squiggly-unnecessary',
 	EditorUnnecessaryInlineDecoration = 'squiggly-inline-unnecessary',
-	EditorDeprecatedInlineDecoration = 'squiggly-inline-deprecated'
+	EditorDeprecatedInlineDecoration = 'inline-deprecated'
 }
 
 export const enum NodeColor {

src/vs/editor/common/modes.ts

@@ -396,6 +396,10 @@ export interface CompletionItem {
 	 * an icon is chosen by the editor.
 	 */
 	kind: CompletionItemKind;
+	/**
+	 * Indicates if this item is deprecated.
+	 */
+	deprecated?: boolean;
 	/**
 	 * A human-readable string with additional information
 	 * about this item, like type or symbol information.

src/vs/editor/contrib/suggest/media/suggest.css

@@ -97,6 +97,13 @@
 	font-weight: bold;
 }
 
+.monaco-editor .suggest-widget .monaco-list .monaco-list-row .inline-deprecated {
+	text-decoration: none; /* override normal inline behavior due to HTML structure */
+}
+.monaco-editor .suggest-widget .monaco-list .monaco-list-row .inline-deprecated span {
+	text-decoration: line-through;
+}
+
 /** Icon styles **/
 
 .monaco-editor .suggest-widget .details > .monaco-scrollable-element > .body > .header > .close,

src/vs/editor/contrib/suggest/suggestWidget.ts

@@ -9,6 +9,7 @@ import { createMatches } from 'vs/base/common/filters';
 import * as strings from 'vs/base/common/strings';
 import { Event, Emitter } from 'vs/base/common/event';
 import { onUnexpectedError } from 'vs/base/common/errors';
+import { ClassName } from 'vs/editor/common/model/intervalTree';
 import { IDisposable, dispose, toDisposable, DisposableStore, Disposable } from 'vs/base/common/lifecycle';
 import { addClass, append, $, hide, removeClass, show, toggleClass, getDomNodePagePosition, hasClass, addDisposableListener } from 'vs/base/browser/dom';
 import { IListVirtualDelegate, IListEvent, IListRenderer, IListMouseEvent } from 'vs/base/browser/ui/list/list';
@@ -195,6 +196,10 @@ class Renderer implements IListRenderer<CompletionItem, ISuggestionTemplateData>
 			];
 		}
 
+		if (suggestion.label && suggestion.deprecated) {
+			labelOptions.extraClasses = (labelOptions.extraClasses || []).concat([ClassName.EditorDeprecatedInlineDecoration]);
+		}
+
 		data.iconLabel.setLabel(suggestion.label, undefined, labelOptions);
 		data.typeLabel.textContent = (suggestion.detail || '').replace(/\n.*$/m, '');
 

src/vs/monaco.d.ts

@@ -4800,6 +4800,10 @@ declare namespace monaco.languages {
 		 * an icon is chosen by the editor.
 		 */
 		kind: CompletionItemKind;
+		/**
+		 * Indicates if this item is deprecated.
+		 */
+		deprecated?: boolean;
 		/**
 		 * A human-readable string with additional information
 		 * about this item, like type or symbol information.

src/vs/vscode.proposed.d.ts

@@ -1307,11 +1307,18 @@ declare module 'vscode' {
 
 	//#region Deprecated support
 
+	export interface CompletionItem {
+		/**
+		 * Indicates if this item is deprecated.
+		 */
+		deprecated?: boolean;
+	}
+
 	export enum DiagnosticTag {
 		/**
-		 * Deprecated or obsolete code.
+		 * Deprecated or obsolete code
 		 *
-		 * Diagnostics with this tag are rendered with a strike through.
+		 * Can be used to style with strikeout or other "obsolete" styling.
 		 */
 		Deprecated = 2,
 	}

src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts

@@ -341,6 +341,7 @@ export class MainThreadLanguageFeatures implements MainThreadLanguageFeaturesSha
 			commitCharacters: data.k,
 			additionalTextEdits: data.l,
 			command: data.m,
+			deprecated: data.n,
 			// not-standard
 			_id: data.x,
 		};

src/vs/workbench/api/common/extHost.protocol.ts

@@ -941,6 +941,7 @@ export interface SuggestDataDto {
 	k/* commitCharacters */?: string[];
 	l/* additionalTextEdits */?: ISingleEditOperation[];
 	m/* command */?: modes.Command;
+	n/* deprecated */?: boolean;
 	// not-standard
 	x?: ChainedCacheId;
 }

src/vs/workbench/api/common/extHostLanguageFeatures.ts

@@ -736,6 +736,7 @@ class SuggestAdapter {
 			k: item.commitCharacters,
 			l: item.additionalTextEdits && item.additionalTextEdits.map(typeConvert.TextEdit.from),
 			m: this._commands.toInternal(item.command, disposables),
+			n: item.deprecated
 		};
 
 		// 'insertText'-logic