Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to Electron 6.x #75802

Merged
merged 602 commits into from
Sep 13, 2019
Merged

chore: Update to Electron 6.x #75802

merged 602 commits into from
Sep 13, 2019

Conversation

deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Jun 20, 2019 •
edited
Loading

Electron: 6.0.7
Nodejs version: 12.4.0
V8 version: 7.6.303.29
Chromium version: 76.0.3809.139

@bpasero bpasero added this to the On Deck milestone Jun 24, 2019
@bpasero bpasero mentioned this pull request Jun 25, 2019
Closed
deepak1556
deepak1556 commented Jul 3, 2019
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@deepak1556 deepak1556 mentioned this pull request Jul 3, 2019
Merged
bpasero
bpasero requested changes Jul 6, 2019
View reviewed changes
src/vs/code/electron-main/windows.ts Outdated
}
dialogPromise.then(({ response, checkboxChecked }: Electron.MessageBoxReturnValue) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepak1556 easier if converted to async/await

@deepak1556 deepak1556 mentioned this pull request Jul 8, 2019
Merged
@deepak1556 deepak1556 marked this pull request as ready for review July 8, 2019 09:31
@svipas
Copy link
Contributor

svipas commented Jul 8, 2019

Sorry for off topic, but I wanted to say thanks to @deepak1556 for this PR, I tried it and finally font weight is fixed with this Electron version. I'm very happy and looking forward to using Insiders with Electron 6.x. 🎆

@bpasero bpasero self-requested a review July 8, 2019 10:22
@bpasero
Copy link
Member

bpasero commented Jul 12, 2019

@deepak1556 fyi see afcd155 for converting dialogs to async and a fix with normalizing paths.

@richard-townsend-arm richard-townsend-arm mentioned this pull request Jul 23, 2019
Merged
4 tasks
@deepak1556
Copy link
Collaborator Author

deepak1556 commented Jul 26, 2019 •
edited
Loading

The macOS crash is due to new helper binaries introduced with electron/electron#19324 , will need to update gulp-atom-electron for rewriting the names of these additional helpers.

Edit: joaomoreno/gulp-atom-electron#55

/cc @joaomoreno

@chpxu
Copy link

chpxu commented Jul 29, 2019

Electron 6.0.0-beta.15 is out

the previous one, .14 updated to Node 12.4.0

Noticed some webview issues fixed which could help?

  • Fixed not working in scriptable popups when nativeWindowOpen is enabled.
  • Fixed setting src on being too slow.
  • Preload scripts for internal <iframe> in are not longer executed when nodeIntegrationInSubFrames is enabled.

@gjsjohnmurray gjsjohnmurray mentioned this pull request Aug 1, 2019
Closed
bpasero
bpasero reviewed Aug 5, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@deepak1556 deepak1556 mentioned this pull request Aug 5, 2019
Closed
@isidorn isidorn mentioned this pull request Aug 7, 2019
Open
This was referenced Aug 13, 2019
Merged
Closed
This was referenced Aug 20, 2019
Merged
Closed
Closed
Closed
Closed
Closed
Closed
deepak1556 and others added 25 commits September 12, 2019 08:22
@deepak1556
chore: update native-watchdog
a990865
Merge remote-tracking branch 'origin/master' into HEAD
4c6f203
Merge remote-tracking branch 'origin/master' into HEAD
ec61e4d
Merge remote-tracking branch 'origin/master' into HEAD
15ef98a
Merge remote-tracking branch 'origin/master' into HEAD
8af6f8c
Merge remote-tracking branch 'origin/master' into HEAD
cc4ab0e
Merge remote-tracking branch 'origin/master' into HEAD
de6f255
Merge remote-tracking branch 'origin/master' into HEAD
5a01469
Merge remote-tracking branch 'origin/master' into HEAD
eae73dc
Merge remote-tracking branch 'origin/master' into HEAD
56fba48
Merge remote-tracking branch 'origin/master' into HEAD
6011ec1
Merge remote-tracking branch 'origin/master' into HEAD
16f16a9
Merge remote-tracking branch 'origin/master' into HEAD
d1a13ae
Merge remote-tracking branch 'origin/master' into HEAD
12118a5
Merge remote-tracking branch 'origin/master' into HEAD
d92cfaf
Merge remote-tracking branch 'origin/master' into HEAD
2555e23
Merge remote-tracking branch 'origin/master' into HEAD
a715df3
@bpasero
partially revert build changes
254f683
@bpasero
build change
17fbc66
Merge remote-tracking branch 'origin/master' into HEAD
7d97d83
Merge remote-tracking branch 'origin/master' into HEAD
8b9dc82
Merge remote-tracking branch 'origin/master' into HEAD
fe0becd
Merge remote-tracking branch 'origin/master' into HEAD
1f06282
Merge remote-tracking branch 'origin/master' into HEAD
e4158b7
@bpasero
Merge branch 'master' into electron-6.0.x
c937d89
@bpasero bpasero merged commit 029e992 into master Sep 13, 2019
@bpasero bpasero deleted the electron-6.0.x branch September 13, 2019 12:53
@WSLUser
Copy link

WSLUser commented Sep 20, 2019

Version update available: electron/electron@10a9e9c

@deepak1556 deepak1556 removed this from the September 2019 milestone Oct 3, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno left review comments

@mjbvz mjbvz mjbvz left review comments

@bpasero bpasero bpasero requested changes

Assignees

@bpasero bpasero

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deepak1556 @svipas @bpasero @chpxu @WSLUser @joaomoreno @mjbvz