Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve vars in text for sendSequence to Terminal #67182

Merged
merged 4 commits into from
Feb 3, 2019
Merged

Resolve vars in text for sendSequence to Terminal #67182

merged 4 commits into from
Feb 3, 2019

Conversation

njkevlani
Copy link
Contributor

@njkevlani njkevlani commented Jan 27, 2019 •
edited
Loading

Fixes #66337

configurationResolverService is used to resolve variables like ${file}, ${fileBasename}, etc.

Can be tested by

{      
	 "key": "ctrl+shift+t",
	"command": "workbench.action.terminal.sendSequence",
	"args": { "text": "cat ${fileBasenameNoExtension}\n" }
}

@Tyriar Tyriar added this to the February 2019 milestone Jan 29, 2019
Tyriar
Tyriar approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Will merge after CI passes

@njkevlani
Copy link
Contributor Author

Sounds great :)

@Tyriar Tyriar merged commit b6d1da9 into microsoft:master Feb 3, 2019
@njkevlani njkevlani deleted the sendSequence_snippets branch February 5, 2019 07:53
@fbehrens
Copy link

fbehrens commented Feb 7, 2019 •
edited
Loading

@Tyriar great that it is implemented, thanks @njkevlani . (How) is it possible to see if the MR is in INSIDERS or RELEASED ?

@njkevlani
Copy link
Contributor Author

njkevlani commented Feb 7, 2019 •
edited
Loading

@fbehrens It is included in code 1.32.0-insider.

@njkevlani
Copy link
Contributor Author

@Tyriar great that it is implemented, thanks @njkevlani . (How) is it possible to see if the MR is in INSIDERS or RELEASED ?

Glad to be helpful :)

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
February 2019
Development

Successfully merging this pull request may close these issues.

Enable use of snippet variables in workbench.action.terminal.sendSequence
3 participants
@njkevlani @fbehrens @Tyriar