Work around #57452 by allowing a raw string for windows shell args #57971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hellArgs.windows
Tyriar
requested changes
Sep 5, 2018
| type: 'array', | ||
| items: { | ||
| type: 'string', | ||
| description: nls.localize('terminal.integrated.shellArgs.windows.array', "An array of string of argments to use when on the Windows terminal. [Read more about configuring the shell](https://code.visualstudio.com/docs/editor/integrated-terminal#_configuration).") |
There was a problem hiding this comment.
I think if we leave this as terminal.integrated.shellArgs.windows it will save the string being re-localized
| }, | ||
| { | ||
| type: 'string', | ||
| description: nls.localize('terminal.integrated.shellArgs.windows.string', "A single string of argments to use when on the Windows terminal. [Read more about configuring the shell](https://code.visualstudio.com/docs/editor/integrated-terminal#_configuration)."), |
There was a problem hiding this comment.
We should explain that the string is in "command-line" format, as described in https://msdn.microsoft.com/en-au/08dfcab2-eb6e-49a4-80eb-87d4076c98c6
Tyriar
approved these changes
Sep 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated terminal.integrated.shellArgs.windows to allow either a string or array of strings to work around logic in node-pty that doesn't correctly escape quotes.
Part of #57452