fix Korean(and Chinese, Japanese) IME behavior (#4541) #5615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR is for issue #4541 - Korean characters problem
Doing so, I added ICompositionEvent that has 'data' field. On 'compositionupdate' events, textarea is changed by composition data.
To show composition letters between the text, the visibleRange is calculated every compositionupdate event with composition word. It can be expensive.
I changed the variable shouldEmptyTextArea to be always true because I think textarea should be empty when composition starts but I didn't test with other browsers (How?).
Symptom (VSCode v1.0, type 'dkssudgktpdy')
Expected (there are two cursors.. it must be fix either)
And When I composite letters between the text, the letters are displayed over the text. But Korean IME doesn't act like that. (type 'gksrmf')
Expected
It is confused that Japanese IME usually show composition letters over the text (in the notepad) but when I tested with Microsoft Word, the composition letters are occupied between the text. (type 'sensei')
After change
But It's same as Microsoft Word