Allow to update require path with Node.js #53964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The question of whether an update is needed can't be answered by looking at just one file. There might be a reference to even a non-module by a |
|
Yes this was a workaround to try to prevent microsoft/TypeScript#24914 from happening. I'll merge this but also add a version check so that we only do this on TS 2.9 and not on 3.0 |
|
It seems a better fix is coming ! Can't wait for it to land on my editor 👍 Thanks @mjbvz and @andy-ms for helping me with this issue and for merging my PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : microsoft/TypeScript#25493
Resolves : #53681
Fix a regression appearing with : 1ee1759
Thanks for your help @mjbvz and @andy-ms 👍
If something should be changed in this PR don't hesitate to notice it to me. 😄