Add unused diagnostic subtype #49646
Conversation
|
Other tags that Roslyn supports: http://source.roslyn.io/#Microsoft.CodeAnalysis/Diagnostic/WellKnownDiagnosticTags.cs,03ef56ba68ffca36 |
src/vs/vscode.d.ts
Outdated
| /** | ||
| * Unused or unnecessary code. | ||
| */ | ||
| Unnecessary = 'unnecessary' |
There was a problem hiding this comment.
|
What other tags do we envision? Any of those used by Roslyn seem very specific: http://source.roslyn.io/#Microsoft.CodeAnalysis/Diagnostic/WellKnownDiagnosticTags.cs,03ef56ba68ffca36,references, in fact I only understand half of them... Is this maybe a dupe of #24682 just with some predefined tags/defaults that we know how to render? Will there be a future with custom rendering of tags? |
|
Further questions to seed some disucssion
|
Fixes #15710 Adds a new `DiagnosticTag` class that provide additional information about a diagnostic. Introduce `DiagnosticTag.Unnecessary` to mark when a diagnostic is for unused / unnecessary code The design comes from Rosyln's diagnostic object and allows us to modify how a diagnostic is rendered without changing its serverity. Hooks up JS and TS to use this new tag. This is controlled by the `javascript.showUnused.enabled` setting which is enabled by default - Introduce a new diagnostic severity for unused. However, using this approach, if a user sets `noUnusedLocals` in their `tsconfig.json`, the resulting diagnostic could only show the squiggly OR be grayed out. Using `customTags` allows us to support both graying out and showing the squiggly - Custom JS/TS implementation using decorators Not themable. We want a standard experience across languages.
- Use numeric enum
|
Merging with proposed api using diagnostic tags. We can revisit this to see if we want try implementing this with a semantic highlighting api next iteration |
Fixes #15710
Adds a new
DiagnosticTagclass that provide additional information about a diagnostic. IntroduceDiagnosticTag.Unnecessaryto mark when a diagnostic is for unused / unnecessary codeThe design comes from Rosyln's diagnostic object and allows us to modify how a diagnostic is rendered without changing its serverity.
Hooks up JS and TS to use this new tag. This is controlled by the
javascript.showUnused.enabledsetting which is enabled by defaultAlternate design considered
Introduce a new diagnostic severity for unused.
However, using this approach, if a user sets
noUnusedLocalsin theirtsconfig.json, the resulting diagnostic could only show the squiggly OR be grayed out. UsingcustomTagsallows us to support both graying out and showing the squigglyCustom JS/TS implementation using decorators
Not themable. We want a standard experience across languages.