Build VSCode using TS 2.4 #30473
Merged
Build VSCode using TS 2.4 #30473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
reviewed
Jul 12, 2017
| contentType: mime.lookup(file), | ||
| cacheControl: 'max-age=31536000, public' | ||
| const blobOptions: azure.BlobService.CreateBlockBlobRequestOptions = { | ||
| contentSettings: { |
There was a problem hiding this comment.
Isn't this going to break something?
There was a problem hiding this comment.
I believe this is the correct API for current version of the azure bindings: https://github.com/Azure/azure-storage-node/blob/master/typings/azure-storage/azure-storage.d.ts#L2778
Not sure if the properties were being applied correctly before or just being ignored
jrieken
reviewed
Jul 12, 2017
There was a problem hiding this comment.
There still some formatting problem, compiler is happy tho. This the guide to run the formatter on all sources: #13373 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build VSCode with TS 2.4
Fixes #28643