Don't Use Async with TPromise in VSCode Codebase #30217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#30216 **Bug** While compiling vscode with TS 2.4, there were around 10 errors reported about async functions that return a `TPromise`. **Fix** I'm checking with the TS team to see if these errors are expected or not. Until then, I believe we need to stop using `TPromise` with async functions. This change changes all instances that use `async` to instead use `then`.
|
Closing in favor of solutions suggested in #30216 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30216
Bug
While compiling vscode with TS 2.4, there were around 10 errors reported about async functions that return a
TPromise.Fix
I'm checking with the TS team to see if these errors are expected or not. As a workaround, I believe we need to stop using
TPromisewith async functions, at least for now.This change changes all instances that use
asyncto instead usethen.