Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find in webview based views (html preview, release notes, extension editor) #30016

Merged
merged 13 commits into from
Jul 7, 2017
Merged

Find in webview based views (html preview, release notes, extension editor) #30016

merged 13 commits into from
Jul 7, 2017

Commits on Jul 2, 2017

  1. Refactored terminalFindWidget into a SimpleFindWidget and used that t… 

    …o provide find for webviews
    Cody Hoover committed Jul 2, 2017
    Configuration menu
    Copy the full SHA
    17a6db3 View commit details
    Browse the repository at this point in the history

  2. Refactored Webvieweditor into an abstract base and a concrete class t… 

    …o respect 'part' separation
    Cody Hoover committed Jul 2, 2017
    Configuration menu
    Copy the full SHA
    aa0e719 View commit details
    Browse the repository at this point in the history

  3. Cleaned up css and images that I forgot to delete

    Cody Hoover committed Jul 2, 2017
    Configuration menu
    Copy the full SHA
    018cfa8 View commit details
    Browse the repository at this point in the history

  4. Reset i18n.js file

    Cody Hoover committed Jul 2, 2017
    Configuration menu
    Copy the full SHA
    7a0f97f View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2017

  1. bind this when passing onThemeChange to themeService.onThemeChange

    Cody Hoover committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    fd868d9 View commit details
    Browse the repository at this point in the history

  2. Add 'CloseWebViewEditorFind' command to close find when pressing escape

    Cody Hoover committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    9812c64 View commit details
    Browse the repository at this point in the history

  3. Ctrl+f now selects text in all SimpleFindWidgets even when buttons ar… 

    …e focused. Aligns with full find widget
    Cody Hoover committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    7aa832c View commit details
    Browse the repository at this point in the history

  4. Fixed issues when reactivating find

    Cody Hoover committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    2819b21 View commit details
    Browse the repository at this point in the history

  5. Register webviewEditor with workbench

    Cody Hoover committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    7a57610 View commit details
    Browse the repository at this point in the history

  6. merged master into branch

    Cody Hoover committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    c40397d View commit details
    Browse the repository at this point in the history

  7. Remove find widget when disposing webview

    Cody Hoover committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    b4e6f20 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2017

  1. Fixed webviewEditor casing in releaseNotesEditor (windows is case ins… 

    …ensitive). Removed registration from workbench to see if it was necessary at all. If it fails again, I'll add it back
    Cody Hoover committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    e52499e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/microsoft/vscode into htm… 

    …lPreview/find/findInputBased
    Cody Hoover committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    6f87f44 View commit details
    Browse the repository at this point in the history