Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Notebook Edit Support #234321

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

DonJayamanne
Copy link
Contributor

Notebook Edit Support

@DonJayamanne
Copy link
Contributor Author

Running into some layering issues

Reading git index versions...
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/api/common/extHostCodeMapper.ts: line 14, col 29, Warning - Bad layering. You are not allowed to access browser from here, allowed layers are: [common] (local/code-layering)
/Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/api/common/extHostCodeMapper.ts: line 14, col 29, Warning - Imports violates 'vscode or vs/base/common/** or vs/base/parts/*/common/** or vs/platform/*/common/** or vs/editor/common/** or vs/editor/contrib/*/common/** or vs/workbench/api/common/** or vs/workbench/common/** or vs/workbench/services/*/common/** or vs/workbench/contrib/*/common/** or vs/workbench/contrib/terminalContrib/*/common/** or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

2 problems
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingService.ts: line 27, col 43, Warning - Imports violates 'vs/base/{common,browser}/** or vs/base/parts/*/{common,browser}/** or vs/platform/*/{common,browser}/** or vs/editor/{common,browser}/** or vs/editor/contrib/*/{common,browser}/** or vs/workbench/{common,browser}/** or vs/workbench/services/*/{common,browser}/** or vs/workbench/contrib/*/{common,browser}/** or vs/workbench/contrib/terminal/terminalContribChatExports* or vs/workbench/contrib/terminal/terminalContribExports* or vscode-notebook-renderer or @vscode/tree-sitter-wasm or @xterm/xterm or @xterm/addon-* or vscode-textmate or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

1 problem
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/contrib/chat/common/chatEditingService.ts: line 18, col 43, Warning - Imports violates 'vs/base/common/** or vs/base/parts/*/common/** or vs/platform/*/common/** or vs/editor/common/** or vs/editor/contrib/*/common/** or vs/workbench/common/** or vs/workbench/services/*/common/** or vs/workbench/contrib/*/common/** or vs/workbench/contrib/terminal/terminalContribChatExports* or vs/workbench/contrib/terminal/terminalContribExports* or vscode-notebook-renderer or @vscode/tree-sitter-wasm or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

1 problem
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/contrib/chat/common/chatModel.ts: line 22, col 43, Warning - Imports violates 'vs/base/common/** or vs/base/parts/*/common/** or vs/platform/*/common/** or vs/editor/common/** or vs/editor/contrib/*/common/** or vs/workbench/common/** or vs/workbench/services/*/common/** or vs/workbench/contrib/*/common/** or vs/workbench/contrib/terminal/terminalContribChatExports* or vs/workbench/contrib/terminal/terminalContribExports* or vscode-notebook-renderer or @vscode/tree-sitter-wasm or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

1 problem
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/contrib/chat/common/chatService.ts: line 17, col 43, Warning - Imports violates 'vs/base/common/** or vs/base/parts/*/common/** or vs/platform/*/common/** or vs/editor/common/** or vs/editor/contrib/*/common/** or vs/workbench/common/** or vs/workbench/services/*/common/** or vs/workbench/contrib/*/common/** or vs/workbench/contrib/terminal/terminalContribChatExports* or vs/workbench/contrib/terminal/terminalContribExports* or vscode-notebook-renderer or @vscode/tree-sitter-wasm or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

1 problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant