Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Windows Start Menu folder to just be an entry #234217 #234218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RedBlackAka
Copy link

This simple change causes the Windows installer to just place an entry in the Start Menu, instead of creating an entire folder, which does not make much sense for a single entry. Solves issue #234217

The resulting change is as following:

From

%appdata%\Microsoft\Windows\Start Menu\Programs\Visual Studio Code\Visual Studio Code.lnk
image

To

%appdata%\Microsoft\Windows\Start Menu\Programs\Visual Studio Code.lnk
image

This simple change causes the Windows installer to just place an entry in the Start Menu, instead of creating an entire folder, which does not make much sense for a single entry.
@sahin52
Copy link

sahin52 commented Nov 19, 2024

Shouldn't it be autostartmenu instead of autoprograms

@RedBlackAka
Copy link
Author

Shouldn't it be autostartmenu instead of autoprograms

Could indeed have mistaken something, I am not too familiar with this and have not tested it.

@sahin52
Copy link

sahin52 commented Nov 19, 2024

I didn't test either, I was just curious.
https://jrsoftware.org/ishelp/index.php?topic=consts
Here it says:

  • autoprograms -> The path to the Programs folder on the Start Menu.
  • autostartmenu -> The path to the top level of the Start Menu.

@sahin52
Copy link

sahin52 commented Nov 19, 2024

I am not sure if that's necessary, you can select the folder while installing vscode:
image
You can select "Don't create a Start Menu folder" option
image

Copy link

@sahin52 sahin52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either use autostartmenu or reject the PR

@RedBlackAka
Copy link
Author

RedBlackAka commented Nov 20, 2024

You can select "Don't create a Start Menu folder" option

However, unselecting this does not create any entry at all. I will fix this PR. I cannot seem to change that message though, although it should not really matter.

Uses the correct autostartmenu name to place the shortcut in the right place.
@RedBlackAka
Copy link
Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants