Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the keybinding for reset zoom #233994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the keybinding for reset zoom #233994

wants to merge 1 commit into from
+1 −1

Conversation

foyoodo
Copy link

@foyoodo foyoodo commented Nov 16, 2024

Before:

SCR-20241116-uflf

After:

SCR-20241116-ufbw

@foyoodo
Copy link
Author

foyoodo commented Nov 16, 2024

It seems that Command/Ctrl + 0 cannot be correctly recognized on Mac and Windows unless it’s the 0 on the Numpad. After changing to Digit0, both 0s can be correctly recognized (test on Mac).

willson9021
willson9021 approved these changes Nov 16, 2024
View reviewed changes
Copy link

@willson9021 willson9021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/vs/workbench/electron-sandbox/actions/windowActions.ts

@DonJayamanne DonJayamanne removed their assignment Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willson9021 willson9021 willson9021 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
triage-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foyoodo @willson9021 @DonJayamanne