Include new shell executables in traverseTree #232493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this would help resolve #224325 (comment) when you say " .. launching an application from the shell won't either." Perhaps julia.exe gets launched from the julialauncher.exe. |
anthonykim1
previously approved these changes
Oct 29, 2024
|
julia.exe is right from my testing, the shell type gets set with that |
|
I see, I wonder if the executable is different for ARM windows vs non-ARM windows |
anthonykim1
approved these changes
Oct 30, 2024
|
@anthonykim1 was that an executable that can start julia.exe? If so then it shouldn't need to be included. |
|
I think so, it was the executable I would get whenever I launched command "Julia REPL Restart". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232424
Not yet tested