Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set input of relay of splice #228813

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Set input of relay of splice #228813

merged 3 commits into from
Sep 17, 2024

Conversation

benibenj
Copy link
Contributor

@benibenj benibenj commented Sep 17, 2024 •
edited
Loading

This pull request sets the input of the onDidSpliceModelRelay relay in the AbstractTree class to the onDidSpliceModel event of the model. This ensures that the relay is properly updated when the model is spliced.

Related #212077

@benibenj benibenj self-assigned this Sep 17, 2024
Base automatically changed from benibenj/lucky-bonobo to main September 17, 2024 10:16
@benibenj benibenj marked this pull request as ready for review September 17, 2024 10:18
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 17, 2024
@benibenj benibenj enabled auto-merge (squash) September 17, 2024 10:44
@benibenj benibenj merged commit dea6413 into main Sep 17, 2024
7 checks passed
@benibenj benibenj deleted the benibenj/bugFix branch September 17, 2024 11:18
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lszomoru lszomoru lszomoru approved these changes

Assignees

@benibenj benibenj

Labels
None yet
Projects
None yet
Milestone
September 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@benibenj @lszomoru