feat: switch to npm as default package manager #226927
Conversation
deepak1556
force-pushed
the
robo/yarn_2_npm
branch
from
ce899ac to
bb9c7df
Compare
deepak1556
force-pushed
the
robo/yarn_2_npm
branch
6 times, most recently
from
7a80822 to
11edb3d
Compare
deepak1556
force-pushed
the
robo/yarn_2_npm
branch
from
4dbdabd to
a7a48f1
Compare
Refs markdown-it/markdown-it@737c95a esbuild step in extensions-ci-pr was previously using markdown-it from root which had userland punycode and was able to compile successfully.
```
✘ [ERROR] Could not resolve "punycode"
extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
14 │ var punycode = require('punycode');
╵ ~~~~~~~~~~
The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```
Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0
We can disable it in a separate PR to keep the required checks happy and also need workflow edit perms.
deepak1556
force-pushed
the
robo/yarn_2_npm
branch
from
a7a48f1 to
44a71a4
Compare
|
We should change the contribution guide. It still directs contributors to use yarn. Edit: I made a PR for wiki. microsoft/vscode-wiki#291 |
|
Speaking as a downstream redistributor, that's precisely the kind of change that warrants bumping up the major version of your software. |
|
I can't speak for the versioning, you should still be able to use the yarn version of commands to launch any of the scripts that were previously used for building packages. The only command that needs a change is the dependency installation |
|
Is there a planned tag release for this change? We are also using vscode-web custom deployment and would like to use npm when building but the latest tag (1.93.1) seems to still use yarn. |
|
@liamlows it will be available from |
The "Code - OSS" repository has altered its dependency manager to "npm" which caused numerous issues for nixpkgs. The most critical issue is the offline cache produced by npm is completely non-reproducible. As a result, it is currently challenging to update the version of "code-oss" (build-from-source version). For now, I am switching from "code-oss" to "vscodium" the binary releases maintained by the community. Link: microsoft/vscode#196795 Link: microsoft/vscode#226927 Link: NixOS/nixpkgs#318673
Fixes #196795