-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide unchanged cells #225011
Merged
Merged
Hide unchanged cells #225011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Aug 7, 2024
src/vs/workbench/contrib/notebook/browser/diff/notebookDiffEditor.ts
Outdated
Show resolved
Hide resolved
DonJayamanne
commented
Aug 7, 2024
@@ -1027,56 +1058,6 @@ export class NotebookTextDiffEditor extends EditorPane implements INotebookTextD | |||
}; | |||
} | |||
|
|||
getCellOutputLayoutInfo(nestedCell: DiffNestedCellViewModel) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead code
DonJayamanne
commented
Aug 7, 2024
DonJayamanne
force-pushed
the
don/issue174152HideCells
branch
4 times, most recently
from
August 8, 2024 02:48
736374e
to
c4b73d2
Compare
bpasero
previously approved these changes
Aug 8, 2024
DonJayamanne
force-pushed
the
don/issue174152HideCells
branch
from
August 8, 2024 20:57
c4b73d2
to
8b1b0fc
Compare
rebornix
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174152