Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unchanged cells #225011

Merged
merged 11 commits into from
Aug 9, 2024
Merged

Hide unchanged cells #225011

merged 11 commits into from
Aug 9, 2024

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Aug 7, 2024

Fixes #174152

Recording 2024-08-07 at 15 28 08

@@ -1027,56 +1058,6 @@ export class NotebookTextDiffEditor extends EditorPane implements INotebookTextD
};
}

getCellOutputLayoutInfo(nestedCell: DiffNestedCellViewModel) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code

@DonJayamanne DonJayamanne force-pushed the don/issue174152HideCells branch 4 times, most recently from 736374e to c4b73d2 Compare August 8, 2024 02:48
@DonJayamanne DonJayamanne marked this pull request as ready for review August 8, 2024 03:38
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 8, 2024
bpasero
bpasero previously approved these changes Aug 8, 2024
@DonJayamanne DonJayamanne enabled auto-merge August 8, 2024 23:44
@DonJayamanne DonJayamanne requested a review from rebornix August 9, 2024 00:23
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@DonJayamanne DonJayamanne merged commit 6fb8d2a into main Aug 9, 2024
6 checks passed
@DonJayamanne DonJayamanne deleted the don/issue174152HideCells branch August 9, 2024 03:35
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook diff - minimap or hide unchanged cells
3 participants