Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal error renderer #210767

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Minimal error renderer #210767

merged 9 commits into from
Apr 22, 2024

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Apr 19, 2024

for #200253

this is behind a setting and off by default for now

initial:
image

expanded:
image

@amunger amunger changed the title Aamunger/error renderer Minimal error renderer Apr 19, 2024
@amunger amunger requested a review from rebornix April 19, 2024 17:03
@amunger amunger marked this pull request as ready for review April 19, 2024 20:46
@vscodenpa vscodenpa added this to the April 2024 milestone Apr 19, 2024
@amunger
Copy link
Contributor Author

amunger commented Apr 19, 2024

without inline margin to line up the button with the header
image

@amunger amunger merged commit 674c62f into main Apr 22, 2024
6 checks passed
@amunger amunger deleted the aamunger/errorRenderer branch April 22, 2024 15:09
sergioengineer pushed a commit to sergioengineer/VimSCode that referenced this pull request Apr 23, 2024
* collapse stack trace

* interaction buttons

* fixup

* place feature behind option

* styling, more cleanup

* test returned link, fix test bug

* test header link, skip header link for old IPython

* padding

* remove inline margin
@microsoft microsoft locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants