Support Multi Editor/Model Highlighting #196024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
Oct 20, 2023
src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts
Outdated
Show resolved
Hide resolved
jrieken
requested changes
Oct 23, 2023
src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts
Outdated
Show resolved
Hide resolved
This was referenced Oct 23, 2023
jrieken
previously approved these changes
Oct 23, 2023
justschen
approved these changes
Oct 24, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
* support multi-editor highlighting * Add experimental multi-document occurrences highlighting option * highlight accross notebook cells even without multi-doc setting * otherModels helper + ResourceMap + fixed removeDecorations * combine textual to just `TextualOccurenceRequest` * fix aggressive dispose/decoration clearing, introduce query interface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30014, #184259
New generic approach to highlighting occurrences across open editors.
Introduced the new setting
editor.multiDocumentOccurrencesHighlightto control the behavior for this feature.