Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add comment widget help dialog #193420

Merged
merged 17 commits into from
Sep 21, 2023
Merged

add comment widget help dialog #193420

merged 17 commits into from
Sep 21, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Sep 19, 2023 •
edited
Loading

No description provided.

@meganrogge meganrogge marked this pull request as draft September 19, 2023 00:26
@meganrogge meganrogge self-assigned this Sep 19, 2023
@meganrogge meganrogge added this to the September 2023 milestone Sep 19, 2023
alexr00
alexr00 reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far, thank you!

@meganrogge meganrogge requested a review from alexr00 September 20, 2023 03:01
@meganrogge meganrogge marked this pull request as ready for review September 20, 2023 03:01
alexr00
alexr00 reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not done revieweing, but here's my review so far so you can see my comments!

src/vs/workbench/contrib/comments/browser/commentsEditorContribution.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/comments/browser/commentsEditorContribution.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/comments/browser/commentsEditorContribution.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/comments/browser/commentsEditorContribution.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/comments/browser/commentsEditorContribution.ts Outdated Show resolved Hide resolved
alexr00
alexr00 requested changes Sep 20, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few more comments!

src/vs/workbench/contrib/comments/browser/comments.contribution.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/accessibility/browser/accessibilityContributions.ts Outdated Show resolved Hide resolved
alexr00
alexr00 previously approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion for the context issue. Otherwise, it looks good. Thank you!

src/vs/workbench/contrib/accessibility/browser/accessibilityContributions.ts Outdated Show resolved Hide resolved
@alexr00 alexr00 mentioned this pull request Sep 21, 2023
Closed
6 tasks
@meganrogge meganrogge merged commit 2f4371e into main Sep 21, 2023
@meganrogge meganrogge deleted the merogge/comment-help branch September 21, 2023 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joyceerhl joyceerhl joyceerhl approved these changes

@alexr00 alexr00 alexr00 left review comments

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@meganrogge @joyceerhl @alexr00