Expose tunnel factory API to non-resolvers #188270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexr00
commented
Jul 19, 2023
| tunnelFeatures?: { | ||
| elevation: boolean; | ||
| /** | ||
| * One of the the options must have the ID "private". |
There was a problem hiding this comment.
We'll probably need to find a better way to do this if we want to consider making this real API. I have just copied this over from resolvers.
alexr00
commented
Jul 19, 2023
| * The localAddress should be the complete local address (ex. localhost:1234) for connecting to the port. Tunnels provided through | ||
| * environmentTunnels are read-only from the forwarded ports UI. | ||
| */ | ||
| environmentTunnels?: TunnelDescription[]; |
There was a problem hiding this comment.
I didn't implement this. It is copied over from resolvers and let's the tunnel provider define some readonly ports at the time of registration. Is this useful?
joaomoreno
approved these changes
Jul 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.