-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GlyphMarginWidget
s
#184375
Implement GlyphMarginWidget
s
#184375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good and in the right direction! I pushed a change to do the lane count computation only once per frame. I also left a couple of comments, plus there are a couple of problems that I've spotted for which I didn't add comments, as I didn't digg deeper to see what are the root causes:
- enable
"typescript.referencesCodeLens.enabled": true
- observe how the breakpoints margins are rendered one line above than before
- observe also that sometimes the breakpoints cannot be removed:
Kapture.2023-06-13.at.15.04.55.mp4
Looked into the off-by-one issue some, it looks like whitespace added by codelenses, as well as the peek view widgets, are not included in the calculation for
I probably need a different way to calculate the |
Fixed! glyph-widgets-fix.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coin)
Fixes #114776
Fixes #183400
Part of #179725
Test adoption for the arrow revert widget (not checked in with this PR):
glyph-widgets.mp4