Re #179224. Customize action for save error. #179727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
reviewed
Apr 12, 2023
src/vs/workbench/services/workingCopy/common/storedFileWorkingCopy.ts
Outdated
Show resolved
Hide resolved
bpasero
requested changes
Apr 18, 2023
src/vs/workbench/contrib/notebook/browser/services/notebookServiceImpl.ts
Outdated
Show resolved
Hide resolved
|
@bpasero thanks for the view, resolved the comments now. |
bpasero
approved these changes
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to customized actions for editor open errors, this PR attempts to add save error actions so notebook can precisely control how it wants users to get the save problem solved, as shown below
Screen.Recording.2023-04-11.at.3.18.24.PM.mov