Hotkey for Windows shell context menu

[mlewand]

First of all thanks for a great editor, it's high time to give you some love back. 🙂

Here's the pull request to fix #15939, which essentially requests for a hotkey in Windows shell context menu.

It adds a "win32ShellHotkey" property in product.json, allowing for hotkey customization.

I suggest setting default value to "o" with following reason:

• "o" is used already by Sublime Text - so if someone switches, he or she is already familiar with it! 😄
• "c" would be a fist pick here, as it's the first letter of "Code", however in default context menu you have already "copy" in context menu, which should have as easy access as possible,

The cool thing is that if you completely skip "win32ShellHotkey" property in product.json instead of crushing it simply won't cause an error in build process but will create no hotkey at all. And if you set it to empty, it will use the first letter from product.nameShort.

Also I think it should be case insensitive, so if you set it doesn't matter if you set it to "o" or "O".

The only thing that I did not implement on purpose is handling for case when product.win32ShellHotkey character is not present in product.nameShort. Ideally we'd want to append it like: "Open with Code - OSS (y)" - but I wanted to keep it clean, and avoid unnecessary logic. Anyway, if that's something you'd like to get, just let me know.

[msftclas]

Hi @mlewand, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[mlewand]

Rebased the branch onto latest master so that we have nice and green tests :) Also I'll close and reopen the PR as I signed CLA yesterday and it still did not take effect...

[msftclas]

Hi @mlewand, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

[joaomoreno]

I'd be more comfortable with this if we simply had a shellNameShort property in package.json, leaving all the magic out of it.

Also, have you verified that simply adding a & before a letter works?

[joaomoreno]

I'd be more comfortable with this if we simply had a shellNameShort property in package.json, leaving all the magic out of it.

Also, have you verified that simply adding a & before a letter works?

[mlewand]

@joaomoreno thanks for the R. Yea I verified this change and it works well.

I'd be more comfortable with this if we simply had a shellNameShort property in package.json, leaving all the magic out of it.

Do you want me to put shellNameShort property alone in the package.json? The reason why I'm asking is that package.json does not contain meta information like that so far.

[joaomoreno]

Sorry, I meant product.json!

[mlewand]

Ahh, now it makes perfect sense 🙂 I'll take a look on that in a spare time.

[mlewand]

@joaomoreno all right the code has been pushed. I have amended the former commit, to keep the history shorter.

[mlewand]

@joaomoreno any chances of getting it in some time soon? It's a pretty trivial fix, while pretty important for Windows keyboard users.

[joaomoreno]

Good job!