-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-file Typescript support in vscode-web #169311
Commits on Sep 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bd9e555 - Browse repository at this point
Copy the full SHA bd9e555View commit details -
Configuration menu - View commit details
-
Copy full SHA for 052c6a8 - Browse repository at this point
Copy the full SHA 052c6a8View commit details -
Because I dont have the default browser set up correctnly on any of my machiens
Configuration menu - View commit details
-
Copy full SHA for ea42f84 - Browse repository at this point
Copy the full SHA ea42f84View commit details -
Add vscode-wasm-typescript dep
And some logging as I figure out how to use it
Configuration menu - View commit details
-
Copy full SHA for 0102053 - Browse repository at this point
Copy the full SHA 0102053View commit details -
Configuration menu - View commit details
-
Copy full SHA for f79188b - Browse repository at this point
Copy the full SHA f79188bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdee414 - Browse repository at this point
Copy the full SHA bdee414View commit details
Commits on Sep 26, 2022
-
Add vscode-wasm-typescript to tsserver.web.js
Use webpack's CopyPlugin transform pattern to do this manually. This is probably a bad idea! It's just for prototyping purposes.
Configuration menu - View commit details
-
Copy full SHA for 4f0ece1 - Browse repository at this point
Copy the full SHA 4f0ece1View commit details
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6f6c491 - Browse repository at this point
Copy the full SHA 6f6c491View commit details -
Fix minor syntax in webpack hack
Nonetheless required for it to work!
Configuration menu - View commit details
-
Copy full SHA for 21eac11 - Browse repository at this point
Copy the full SHA 21eac11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2afbf36 - Browse repository at this point
Copy the full SHA 2afbf36View commit details -
Another typo. Guess my local test wasn't running the contents really
Configuration menu - View commit details
-
Copy full SHA for 80d2729 - Browse repository at this point
Copy the full SHA 80d2729View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d88cc9 - Browse repository at this point
Copy the full SHA 9d88cc9View commit details
Commits on Sep 29, 2022
-
tsserver.web.js comes from local builds
Also: - tsserver.js is no longer minified - log crossOriginIsolated
Configuration menu - View commit details
-
Copy full SHA for 7db6575 - Browse repository at this point
Copy the full SHA 7db6575View commit details
Commits on Sep 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f67a08e - Browse repository at this point
Copy the full SHA f67a08eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 092c565 - Browse repository at this point
Copy the full SHA 092c565View commit details
Commits on Oct 4, 2022
-
Move sync-api setup code to serverProcess.browser.ts
Because it's browser-specific
Configuration menu - View commit details
-
Copy full SHA for bd93d21 - Browse repository at this point
Copy the full SHA bd93d21View commit details
Commits on Oct 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 293b6e3 - Browse repository at this point
Copy the full SHA 293b6e3View commit details
Commits on Oct 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 124acc8 - Browse repository at this point
Copy the full SHA 124acc8View commit details
Commits on Oct 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 40a2626 - Browse repository at this point
Copy the full SHA 40a2626View commit details
Commits on Oct 17, 2022
-
Build only the ts parts of tsserver.web.js, don't rebuild the vscode extension. This is a lot faster.
Configuration menu - View commit details
-
Copy full SHA for 060d671 - Browse repository at this point
Copy the full SHA 060d671View commit details
Commits on Oct 21, 2022
-
Sheetal showed me the correct way to create a verbose logger instead.
Configuration menu - View commit details
-
Copy full SHA for fac861b - Browse repository at this point
Copy the full SHA fac861bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b8c46 - Browse repository at this point
Copy the full SHA 65b8c46View commit details
Commits on Oct 24, 2022
-
Add vscode-test-web to semantic-supported schemes
And make isWeb support semantic mode.
Configuration menu - View commit details
-
Copy full SHA for d8f495b - Browse repository at this point
Copy the full SHA d8f495bView commit details
Commits on Oct 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7a1eb58 - Browse repository at this point
Copy the full SHA 7a1eb58View commit details
Commits on Nov 4, 2022
-
Also paste in some example code for cancellation, which is not finished at all.
Configuration menu - View commit details
-
Copy full SHA for 4ee41e2 - Browse repository at this point
Copy the full SHA 4ee41e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72a972c - Browse repository at this point
Copy the full SHA 72a972cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6509c48 - Browse repository at this point
Copy the full SHA 6509c48View commit details
Commits on Dec 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2c32ab4 - Browse repository at this point
Copy the full SHA 2c32ab4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c56e69 - Browse repository at this point
Copy the full SHA 6c56e69View commit details
Commits on Dec 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 673869c - Browse repository at this point
Copy the full SHA 673869cView commit details -
Initial prototype of cancellation
It compiles and looks kind of plausible. But I haven't tested it yet.
Configuration menu - View commit details
-
Copy full SHA for 741e3a8 - Browse repository at this point
Copy the full SHA 741e3a8View commit details
Commits on Dec 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a24ae56 - Browse repository at this point
Copy the full SHA a24ae56View commit details -
Move watches to a separate MessagePort
Further simplifies the message dispatch code by shifting complexity to setup. And the setup is straight-line code.
Configuration menu - View commit details
-
Copy full SHA for 6f1415e - Browse repository at this point
Copy the full SHA 6f1415eView commit details
Commits on Dec 8, 2022
-
switch vscode-web from in-memory to real filesystem
goto-def is currently broken because some part of main vscode still needs treat the files as in-memory, though.
Configuration menu - View commit details
-
Copy full SHA for 4b19dee - Browse repository at this point
Copy the full SHA 4b19deeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c17bf33 - Browse repository at this point
Copy the full SHA c17bf33View commit details
Commits on Dec 15, 2022
-
Encode scheme and authority in TS filenames
Like the previous host did, but without the leading ^ that TS hard-codes as "in-memory". The tsserver host needs to know about the encoding, but the translation is in a single function. This also means that displayed file paths are prefixed with /scheme/authority (/vscode-test-web/mount in my testing), but I think that's fine.
Configuration menu - View commit details
-
Copy full SHA for 6fade7c - Browse repository at this point
Copy the full SHA 6fade7cView commit details -
Lift parseUri outside createServerHost
I'm not using it to set the schema/authority for getCurrentDirectory right now, so there's no shared state to mutate.
Configuration menu - View commit details
-
Copy full SHA for 68047c7 - Browse repository at this point
Copy the full SHA 68047c7View commit details -
Special-case URI of lib*d.ts in webServer.toResource
Similar to the special-casing in typescriptServiceClient.toResource. Also requires passing in the extensionUri. This feels like it's breaking through at least one abstraction layer, which might be a problem.
Configuration menu - View commit details
-
Copy full SHA for 9ffdb8e - Browse repository at this point
Copy the full SHA 9ffdb8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 629804c - Browse repository at this point
Copy the full SHA 629804cView commit details
Commits on Dec 16, 2022
-
1. Simplify cancellation checking in web tsserver host to match the checking in typescript's node host. 2. Move cancellation of request in the extension to tryCancelRequest from sendNextRequests. 3. Only send cancellation via node or web cancellation, not both.
Configuration menu - View commit details
-
Copy full SHA for 0f0e155 - Browse repository at this point
Copy the full SHA 0f0e155View commit details -
Configuration menu - View commit details
-
Copy full SHA for 675401e - Browse repository at this point
Copy the full SHA 675401eView commit details
Commits on Dec 19, 2022
-
Also add some TODO comments for the revision to watches.
Configuration menu - View commit details
-
Copy full SHA for 41be877 - Browse repository at this point
Copy the full SHA 41be877View commit details
Commits on Dec 22, 2022
-
Add cancellation bit to each (cancellable) request, locally fix an is…
…sue with retrieving the cancellation bit
Configuration menu - View commit details
-
Copy full SHA for 8639b4b - Browse repository at this point
Copy the full SHA 8639b4bView commit details -
Switch to per-file/directory watches
Watching the entire filesystem recursively is supposed to be inefficient. Not done yet: there is an error when watching directories, but it works. And I can't tell whether watching files works yet.
Configuration menu - View commit details
-
Copy full SHA for 0138958 - Browse repository at this point
Copy the full SHA 0138958View commit details
Commits on Dec 27, 2022
-
Parse --serverMode partialSemantic in webServer
Now the syntax server actually runs as a syntax server.
Configuration menu - View commit details
-
Copy full SHA for a8774f3 - Browse repository at this point
Copy the full SHA a8774f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52506b6 - Browse repository at this point
Copy the full SHA 52506b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f1966f - Browse repository at this point
Copy the full SHA 6f1966fView commit details
Commits on Dec 29, 2022
-
1. Remove a little logging. 2. Correct failure return value for getFileSize 3. Reorder some methods and parameters.
Configuration menu - View commit details
-
Copy full SHA for a07f98c - Browse repository at this point
Copy the full SHA a07f98cView commit details
Commits on Jan 6, 2023
-
Switch to markdown extension's FileWatcherManager
I'm not sure if it's OK to depend on a module from another extension; it's probably better to include the files from a central place instead.
Configuration menu - View commit details
-
Copy full SHA for 0288f0f - Browse repository at this point
Copy the full SHA 0288f0fView commit details
Commits on Jan 9, 2023
-
1. Copy and adapt implementations from node host where possible. 2. Note questions for the PR elsewhere. 3. Remove logging except for caught exceptions.
Configuration menu - View commit details
-
Copy full SHA for 1c52093 - Browse repository at this point
Copy the full SHA 1c52093View commit details -
Configuration menu - View commit details
-
Copy full SHA for f48e065 - Browse repository at this point
Copy the full SHA f48e065View commit details
Commits on Jan 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f5dade7 - Browse repository at this point
Copy the full SHA f5dade7View commit details -
Add setting to enable/disable semantic mode on web
Also gate it behind a check to `crossOriginIsolated`
Configuration menu - View commit details
-
Copy full SHA for cde1ffc - Browse repository at this point
Copy the full SHA cde1ffcView commit details -
Re-order and re-arrange code to minimise PR diff
It won't minimise it *much*, but I also consolidated some unnecessarily-spread-out code that will be easier to read in the long term, and possibly easier to read in diff form as well.
Configuration menu - View commit details
-
Copy full SHA for 8f130c0 - Browse repository at this point
Copy the full SHA 8f130c0View commit details -
Copy fileWatchingManager to typescript extension
Copy from markdown extension to typescript extension. I used the existing dependencies in the typescript extension, but verified that they would work the same.
Configuration menu - View commit details
-
Copy full SHA for 4952d5d - Browse repository at this point
Copy the full SHA 4952d5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a72e7d - Browse repository at this point
Copy the full SHA 8a72e7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98ae48e - Browse repository at this point
Copy the full SHA 98ae48eView commit details
Commits on Jan 11, 2023
-
Extract isProjectWideIntellisenseOnWebEnabled and keep using in-memor…
…y prefix when project wide intellisense is disabled
Configuration menu - View commit details
-
Copy full SHA for 9069220 - Browse repository at this point
Copy the full SHA 9069220View commit details
Commits on Jan 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6057abc - Browse repository at this point
Copy the full SHA 6057abcView commit details -
Remove symlink support and fix typo
Symlinks are implicitly supported by the filesystem right now.
Configuration menu - View commit details
-
Copy full SHA for e36a6db - Browse repository at this point
Copy the full SHA e36a6dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b2a13c - Browse repository at this point
Copy the full SHA 0b2a13cView commit details -
Configuration menu - View commit details
-
Copy full SHA for aad4f87 - Browse repository at this point
Copy the full SHA aad4f87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a1b2c3 - Browse repository at this point
Copy the full SHA 6a1b2c3View commit details