Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some potential causes of #161520 #161550

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Sep 23, 2022

  • initializeMarkup should always fire initializedMarkup, even if an exception is thrown while initializing

  • MarkupCell should always resolve its ready promise, even if an exception is thrown during rendering

Unclear if either of these were the causes of #161520, but still good to fix them

- initializeMarkup should always fire `initializedMarkup`, even if an exception is thrown while initializing

- `MarkupCell` should always resolve its `ready` property, even if an exception is thrown during rendering

Unclear if either of these were the causes of microsoft#161520, but still good to fix them
@mjbvz mjbvz added this to the September 2022 milestone Sep 23, 2022
@mjbvz mjbvz self-assigned this Sep 23, 2022
@mjbvz mjbvz merged commit f8f228d into microsoft:main Sep 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants