RPM packaging: Use standard macros #153247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the `/usr/bin/code` symlink during %install so that the package owns and manages it. Also, make it relative (for better relocatability).
- Sort directory creation into same order as copying & %files list - Break up into sections, label with a comment above each
- Once `@@name@@` is replaced into the spec file as the `Name:`, it can be referenced with the RPM macro `%{name}` - The installation directories corresponding to `/usr/bin/` and `/usr/share/` are defined in the RPM macros `%{_bindir}` and `%{_datadir}`
|
|
deepak1556
reviewed
Jul 6, 2022
Co-authored-by: Robo <[email protected]>
deepak1556
approved these changes
Jul 6, 2022
|
I plan on approving + merging this PR next week. |
|
Sorry, I forgot to merge the PR 🤦♂️ |
rzhao271
approved these changes
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, which builds on #142907 (and stems from the discussion in #142907 (comment)), updates the RPM spec file to use standard RPM macros where appropriate in the package definition.
@@NAME@@is replaced into the specfile definition ofName:, its value can be referenced using the%{name}macro, requiring less substitution on the template specfile.%{_bindir}and%(_datadir}are preferred, when specifying paths for installed files (either in the%{builddir}tree, during%install, or in the%fileslist).Also:
%installsection are now sorted to match the other references to those paths throughout the file%installup into coarse sections, each labeled with a preceding comment