Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimentation in typescript-language-features #152244

Conversation

DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Jun 15, 2022

This PR is a work-in-progress to perform experiments in the typescript-language-features extension so that we can figure out what users respond best to in experiences like the upcoming JavaScript walkthroughs (#151665).

vscode-tas-client usage recommendations seem pretty undocumented, so I took some inspiration from

and I'm hoping to get team guidance on next steps to see if it's working, along with hearing about anything that I've gotten blatantly wrong.

CC @mjbvz @connor4312 @devinvalenciano @luabud @isidorn @daytonellwanger

@DanielRosenwasser
Copy link
Member Author

How exactly should I add a dependency without updating the lockfile?

@mjbvz mjbvz self-assigned this Jun 15, 2022
@mjbvz mjbvz self-requested a review June 15, 2022 19:57
@connor4312
Copy link
Member

This looks sane to me

@mjbvz mjbvz added this to the June 2022 milestone Jun 15, 2022
@DanielRosenwasser DanielRosenwasser marked this pull request as ready for review June 15, 2022 22:01
@DanielRosenwasser
Copy link
Member Author

I think the only TODO in the code itself is to actually instantiate the service on extension initialization.

@daytonellwanger
Copy link

LGTM 👍

Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. @DanielRosenwasser I think I'll have to re-submit this PR since it changes the lock file. There's not currently good way for non-team members to update that. Let me know if it is ready to be merged

@DanielRosenwasser
Copy link
Member Author

Should be ready - if you'd like, you can cherry-pick into its own branch (or alternatively you can just merge in spite of the CI if you're all cool with that).

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 27, 2022

Cherry-picking this in with #153358

Thanks @DanielRosenwasser!

@mjbvz mjbvz closed this Jun 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants