Add suggestions for ext filter in the Settings editor search widget #148076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
commented
Apr 25, 2022
| @@ -269,6 +274,10 @@ export class SettingsEditor2 extends EditorPane { | |||
| if (ENABLE_LANGUAGE_FILTER && !SettingsEditor2.SUGGESTIONS.includes(`@${LANGUAGE_SETTING_TAG}`)) { | |||
| SettingsEditor2.SUGGESTIONS.push(`@${LANGUAGE_SETTING_TAG}`); | |||
| } | |||
|
|
|||
| extensionManagementService.getInstalled(ExtensionType.System).then(extensions => { | |||
There was a problem hiding this comment.
This is a similar hack that PreferencesSearchService uses to "unwrap" the result from the async API.
rzhao271
commented
Apr 25, 2022
| @@ -107,7 +107,7 @@ export class SettingsSearchFilterDropdownMenuActionViewItem extends DropdownMenu | |||
| localize('extSettingsSearch', "Extension ID..."), | |||
| localize('extSettingsSearchTooltip', "Add extension ID filter"), | |||
| `@${EXTENSION_SETTING_TAG}`, | |||
| false | |||
| true | |||
There was a problem hiding this comment.
This change makes it so the completions list activates after the user selects the option from the funnel button.
roblourens
approved these changes
Apr 25, 2022
| const installedExtensionsTags = this.installedExtensionIds.map(extensionId => { | ||
| return `@${EXTENSION_SETTING_TAG}${extensionId} `; | ||
| }).sort(); | ||
| return installedExtensionsTags.filter(extFilter => !query.includes(extFilter)); |
There was a problem hiding this comment.
I wonder whether we can show the "display name" of the extension in the suggest widget as well? Maybe you can return a "detail" or "description" to show next to the ID
There was a problem hiding this comment.
I'll look into returning completion items for that case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #145710
This PR adds suggestions for the
@extfilter in the Settings editor search widget, so now when a user types@ext:, or when they select the "Extension ID..." option from the funnel button, a list of installed extension IDs will pop up as suggestions to choose from.