Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re #147183. Support editor options in IDefaultEditor #147816

Merged
merged 4 commits into from
Apr 21, 2022
Merged

re #147183. Support editor options in IDefaultEditor #147816

merged 4 commits into from
Apr 21, 2022

Conversation

rebornix
Copy link
Member

This PR fixes #147183. It attempts to introduce IEditorOptions to IDefaultLayout, which can be transported to any workbench editor. It will allow embedders to construct a notebook editor options for notebook resources.

@rebornix rebornix self-assigned this Apr 21, 2022
@rebornix rebornix requested a review from bpasero April 21, 2022 04:21
@rebornix rebornix mentioned this pull request Apr 21, 2022
Closed
bpasero
bpasero requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor feedback, please merge after, no need to review again.

src/vs/workbench/common/editor.ts Outdated Show resolved Hide resolved
src/vs/platform/window/common/window.ts Show resolved Hide resolved
@rebornix rebornix merged commit 936ce0b into main Apr 21, 2022
@rebornix rebornix deleted the rebornix/supportEditorOptionsInDefaultEditor branch April 21, 2022 20:01
aeschli pushed a commit that referenced this pull request May 2, 2022
@rebornix @aeschli
re #147183. Support editor options in IDefaultEditor (#147816)
f806b0e 
* re #147183. Support editor options in IDefaultEditor

* Add deprecation tag.

* Avoid type casing.

* 💄
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero requested changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support index based url for notebook cells
2 participants
@rebornix @bpasero