code server web: have a commit in the static and callback routes #147311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
force-pushed
the
aeschli/commitInRoute
branch
from
7e4c7fe to
d364f56
Compare
alexdima
approved these changes
May 2, 2022
alexdima
approved these changes
May 3, 2022
| @@ -148,7 +159,7 @@ export class WebClientServer { | |||
| return serveError(req, res, 400, `Bad request.`); | |||
| } | |||
|
|
|||
| return serveFile(this._logService, req, res, filePath, headers); | |||
| return serveFile(filePath, this._environmentService.isBuilt ? CacheControl.NO_EXPIRY : CacheControl.NO_CACHING, this._logService, req, res, headers); | |||
There was a problem hiding this comment.
When running from source, this should be CacheControl.ETAG to maintain existing behaviour.
There was a problem hiding this comment.
When running from sources I prefer no caching and I don't see a benefit of sticking to ETags. So unless you strongly object, I'd make that change.
|
Merged the web server changes. I'll create a new PR for the remaining changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bult-in web server used for code server web accesses sources and artifacts using the
/staticand/callbackroutes.The pr adds a
quality-commitsegment in from of these.That helps with caching and allows to hand over from one server (running an older version) to another server, running the latest version.