Adding support for RTL languages for readme markdown preview. #139644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mjbvz
approved these changes
Jan 3, 2022
| @@ -25,6 +25,7 @@ const pluginSourceMap: MarkdownIt.PluginSimple = (md): void => { | |||
| if (token.map && token.type !== 'inline') { | |||
| token.attrSet('data-line', String(token.map[0])); | |||
| token.attrJoin('class', 'code-line'); | |||
| token.attrJoin('dir', 'auto'); | |||
There was a problem hiding this comment.
Is this required or is dir inherited by child elements?
There was a problem hiding this comment.
It is required. Because dir="auto" just looks at the first paragraph and apply direction to all the child element.
Childs just inherit rtl or ltr. Childs doesn't inherit auto and it is not so smart.
I think we can only add dir="auto" to the code-line classes (childs). But for markdown-body class is optional.
SMSadegh19
commented
Jan 4, 2022
| @@ -178,7 +179,7 @@ export class MarkdownEngine { | |||
|
|
|||
| return engine.parse(text.replace(UNICODE_NEWLINE_REGEX, ''), {}); | |||
| } | |||
|
|
|||
| public resetSlugCount(): void { | |||
There was a problem hiding this comment.
Here we have an empty extra line here.
raghavthind2005
approved these changes
Jan 5, 2022
|
Thanks! Will be in the next VS Code insiders build and scheduled to be released as part of VS Code 1.64 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #139643
I'm solving this issue as a good-first-issue. If you think anything is wrong please help me to solve it. :)