Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finalize terminal location API #138530

Merged
merged 4 commits into from
Dec 6, 2021
Merged

finalize terminal location API #138530

merged 4 commits into from
Dec 6, 2021

Conversation

meganrogge
Copy link
Contributor

This PR fixes #45407

@meganrogge meganrogge self-assigned this Dec 6, 2021
@meganrogge meganrogge requested a review from Tyriar December 6, 2021 17:14
@meganrogge meganrogge added this to the December 2021 milestone Dec 6, 2021
@meganrogge meganrogge requested a review from jrieken December 6, 2021 17:30
jrieken
jrieken requested changes Dec 6, 2021
View reviewed changes
src/vscode-dts/vscode.d.ts Outdated Show resolved Hide resolved
Tyriar
Tyriar approved these changes Dec 6, 2021
View reviewed changes
src/vscode-dts/vscode.d.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge merged commit 08fe3f2 into main Dec 6, 2021
@meganrogge meganrogge deleted the merogge/finalize-location branch December 6, 2021 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken requested changes

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
January 2022
Development

Successfully merging this pull request may close these issues.

Add an API for specifying terminal location
3 participants
@meganrogge @jrieken @Tyriar