Add terminal location API #131028
Merged
Add terminal location API #131028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Aug 17, 2021
meganrogge
commented
Aug 17, 2021
Tyriar
requested changes
Aug 17, 2021
src/vs/workbench/contrib/terminal/browser/terminalEditorService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
Tyriar
requested changes
Aug 19, 2021
| @@ -639,11 +651,27 @@ export abstract class BaseExtHostTerminalService extends Disposable implements I | |||
| if (!profile || !('options' in profile)) { | |||
| throw new Error(`No terminal profile options provided for id "${id}"`); | |||
| } | |||
|
|
|||
| const internalOptions: ITerminalInternalOptions = this._resolveParentTerminal(options); | |||
There was a problem hiding this comment.
If we convert to/from ExtHostTerminalIdentifier whenever we go between mainThread and extHost, can we avoid this?
There was a problem hiding this comment.
no because this is the very way we are able to pass between them. perhaps I'm not understanding
Comment on lines
51
to
55
| export interface ITerminalInternalOptions { | ||
| isFeatureTerminal?: boolean; | ||
| useShellEnvironment?: boolean; | ||
| isSplitTerminal?: boolean; | ||
| target?: TerminalLocation; | ||
| resolvedExtHostTerminal?: ExtHostTerminal; | ||
| } |
There was a problem hiding this comment.
Is it possible to move location to the actual options instead of internal options?
There was a problem hiding this comment.
not possible because the types of location differ between MainThread and extHostTerminalService, but they share the TerminalLaunchConfig interface
Co-authored-by: Daniel Imms <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #45407