Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: native module bundling in universal builds #130916

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

deepak1556
Copy link
Collaborator

Cherry-pick 49af1cb

Refs #130222

@deepak1556 deepak1556 self-assigned this Aug 16, 2021
@deepak1556 deepak1556 requested a review from rzhao271 August 16, 2021 15:30
@deepak1556 deepak1556 added the candidate Issue identified as probable candidate for fixing in the next release label Aug 16, 2021
@deepak1556 deepak1556 added this to the July 2021 Recovery milestone Aug 16, 2021
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A debt task would be to move vscode-universal-bundler to @vscode/universal-bundler

@rzhao271 rzhao271 merged commit 5ed9db6 into release/1.59 Aug 16, 2021
@rzhao271 rzhao271 deleted the robo/fix_universal_builds branch August 16, 2021 16:46
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants