fix: maxResults config value is now applied to searchEditor #130531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Will look into the perf concerns to see if a non-infinite maximum is needed when the value is null. |
I'd like to know how it is going to be handled later, thanks for taking your time! |
AiverReaver
pushed a commit
to AiverReaver/vscode
that referenced
this pull request
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #129153
as-is:
searchEditor's maxResult value is fixed to 10000
to-be:
searchEditor utilizes maxResult config as searchView
If the change is not sufficient, an advice would be appreciated!