Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline values support #129382

Closed

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jul 26, 2021

This PR fixes #119489 . Would also be downstream of microsoft/TypeScript#45173

%KE0NL%%C S%2OVZPB{ } L

/cc: @mjbvz @connor4312

@connor4312
Copy link
Member

This is cool, thanks for your work on it! I'll leave it to Matt to review this change as he's far more familiar with this code.

@connor4312 connor4312 requested a review from mjbvz July 26, 2021 17:02
@mjbvz mjbvz added this to the August 2021 milestone Jul 27, 2021
@mjbvz mjbvz modified the milestones: August 2021, September 2021 Aug 24, 2021
@mjbvz mjbvz modified the milestones: September 2021, October 2021 Sep 29, 2021
@alexr00 alexr00 modified the milestones: October 2021, November 2021 Nov 8, 2021
@mjbvz mjbvz modified the milestones: November 2021, December 2021 Dec 6, 2021
@mjbvz mjbvz modified the milestones: January 2022, February 2022 Jan 28, 2022
@Tyriar Tyriar modified the milestones: February 2022, March 2022 Feb 28, 2022
@mjbvz mjbvz modified the milestones: March 2022, Backlog Mar 23, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 23, 2022

@Kingwl @connor4312 From the typescript side, I believe we agreed inline values would ship as a plugin instead of part of core. Do you know if such a plugin has been developed yet?

@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 24, 2022

@Kingwl @connor4312 From the typescript side, I believe we agreed inline values would ship as a plugin instead of part of core. Do you know if such a plugin has been developed yet?

AFAIK, nope.

@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 25, 2022

@Kingwl @connor4312 From the typescript side, I believe we agreed inline values would ship as a plugin instead of part of core. Do you know if such a plugin has been developed yet?

Emmmmm, should it be a builtin ts plugin provided by ts extension?

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 29, 2022

@Kingwl Yes that makes sense to me. The TS plugin needs to be shipped as its own node module but we can bundle it as part of VS Code's built-in TS extension

@Kingwl
Copy link
Contributor Author

Kingwl commented Apr 1, 2022

Happy to work on this If I may.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement InlineValueProvider for TypeScript
5 participants