-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline values support #129382
Add inline values support #129382
Conversation
This is cool, thanks for your work on it! I'll leave it to Matt to review this change as he's far more familiar with this code. |
@Kingwl @connor4312 From the typescript side, I believe we agreed inline values would ship as a plugin instead of part of core. Do you know if such a plugin has been developed yet? |
AFAIK, nope. |
Emmmmm, should it be a builtin ts plugin provided by ts extension? |
@Kingwl Yes that makes sense to me. The TS plugin needs to be shipped as its own node module but we can bundle it as part of VS Code's built-in TS extension |
Happy to work on this If I may. |
This PR fixes #119489 . Would also be downstream of microsoft/TypeScript#45173
/cc: @mjbvz @connor4312