Fallback to 80x30 dimensions in terminal #128700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where when the terminal would be created without a container it initializes with 0x0 dimensions which gets set to the minimum of 2x1 instead of the expected default of 80x30 (which node-pty respects). This 80x30 is now hardcoded in VS Code. Fixes #128342
This fixes the following case: 1. Create and split the terminal 2. Hide the panel 3. Create a terminal in the background 4. Show it, the dimensions were wrong
Tyriar
added
the
candidate
meganrogge
approved these changes
Jul 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to 80x30 dimensions in terminal
This fixes an issue where when the terminal would be created without a container
it initializes with 0x0 dimensions which gets set to the minimum of 2x1 instead
of the expected default of 80x30 (which node-pty respects). This 80x30 is now
hardcoded in VS Code.
Fixes #128342
Resize terminal when it's shown
This fixes the following case: