Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix terminal editor bugs #127963

Merged
merged 9 commits into from
Jul 6, 2021
Merged

fix terminal editor bugs #127963

merged 9 commits into from
Jul 6, 2021

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jul 4, 2021 •
edited
Loading

This PR fixes #126469
fixes #127901
fixes #127968

@meganrogge meganrogge requested a review from Tyriar July 4, 2021 18:06
@meganrogge meganrogge self-assigned this Jul 4, 2021
@meganrogge meganrogge added this to the June 2021 milestone Jul 4, 2021
@meganrogge meganrogge changed the title fix terminal editor panel bug via clearInput fix terminal editor bugs Jul 4, 2021
Tyriar
Tyriar approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine

@meganrogge meganrogge enabled auto-merge (squash) July 6, 2021 15:02
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Jul 6, 2021
@meganrogge meganrogge merged commit 4c95275 into release/1.58 Jul 6, 2021
@meganrogge meganrogge deleted the merogge/term-editor branch July 6, 2021 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
June 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@meganrogge @Tyriar