Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setuid helper permission #126798

Merged
merged 5 commits into from
Jun 22, 2021
Merged

fix: setuid helper permission #126798

merged 5 commits into from
Jun 22, 2021

Conversation

deepak1556
Copy link
Collaborator

Fixes #126029
Fixes #126019
Fixes #126007

@deepak1556 deepak1556 self-assigned this Jun 21, 2021
@deepak1556 deepak1556 added this to the June 2021 milestone Jun 21, 2021
@deepak1556 deepak1556 force-pushed the robo/fix_setuid_permissin branch 3 times, most recently from 189ba22 to 4c56539 Compare June 21, 2021 12:52
@deepak1556
Copy link
Collaborator Author

deepak1556 commented Jun 22, 2021

Run with --disable-namespace-sandbox to verify:

  • deb
  • rpm
  • snap

deepak1556 added a commit to microsoft/vscode-linux-build-agent that referenced this pull request Jun 22, 2021
@deepak1556 deepak1556 force-pushed the robo/fix_setuid_permissin branch from 246ae73 to 429bf99 Compare June 22, 2021 05:03
@deepak1556
Copy link
Collaborator Author

deepak1556 commented Jun 22, 2021

arm ci failures depend on new builds from https://github.com/microsoft/vscode-linux-build-agent which is currently having trouble with AAD

@deepak1556 deepak1556 merged commit 92999c3 into main Jun 22, 2021
@deepak1556 deepak1556 deleted the robo/fix_setuid_permissin branch June 22, 2021 15:42
Copy link

@Stirfry70 Stirfry70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool

@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants