Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AppleScript from terminal. references #119787 #119788

Closed
wants to merge 1 commit into from
Closed

Allow AppleScript from terminal. references #119787 #119788

wants to merge 1 commit into from

Conversation

kroko
Copy link

@kroko kroko commented Mar 24, 2021

Signed-off-by: kroko [email protected]

This PR fixes #119787

@ghost
Copy link

ghost commented Mar 24, 2021

CLA assistant check
All CLA requirements met.

@kroko
Copy link
Author

kroko commented Mar 24, 2021

I assume that @meganrogge might not be the right assignee as it is not xterm.js related per se. 😄 It relates to build configuration for macOS - electron-builder setup, where stamping usual suspects of Electron entitlements and Info.plist keys on VSCode will not cut it, especially in the times of ever tighter gatekeeper. Please reassign, poking @deepak1556 and @joaomoreno as you seem to be involved in PRs related to build configs.

@deepak1556
Copy link
Collaborator

Thanks for the PR, closing in favor of 325bea6 which consolidates some more cleanup.

@deepak1556 deepak1556 closed this Mar 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS entitlements and entries for Info.plist disallow developing and running certain types of apps via VSCode
3 participants