Add shellPath to allow user specify preferred shell. Fix #10917 #11700
Conversation
|
Hi @octref, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| @@ -3497,9 +3497,10 @@ declare namespace vscode { | |||
| * [Terminal.show](#Terminal.show) in order to show the terminal panel. | |||
| * | |||
| * @param name Optional human-readable string which will be used to represent the terminal in the UI. | |||
| * @param shellPath Path to the user-requested shell executable that will be used in the terminal | |||
There was a problem hiding this comment.
Change this to:
@param shellPath Optional path to a custom shell executable to be used in the terminal.
| @@ -85,8 +87,8 @@ export class ExtHostTerminalService { | |||
| this._proxy = threadService.get(MainContext.MainThreadTerminalService); | |||
| } | |||
|
|
|||
| public createTerminal(name?: string): vscode.Terminal { | |||
| return new ExtHostTerminal(this._proxy, -1, name); | |||
| public createTerminal(name?: string, path?: string): vscode.Terminal { | |||
|
Coverage decreased (-0.004%) to 61.834% when pulling 61ef6925d14bb59e9d310627066f77784b49c241 on octref/10917 into 3375a6d on master. |
|
Updated to address comments. |
|
Coverage decreased (-0.004%) to 61.834% when pulling 61ef6925d14bb59e9d310627066f77784b49c241 on octref/10917 into 3375a6d on master. |
|
I'm going to merge this as is without |
|
Thanks. Should I do the shellArgs now or wait for your refactor? |
No description provided.