Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets terminal font to monospace automatically when incorrectly set to… #112562

Closed
wants to merge 1 commit into from

Conversation

youngmac
Copy link

… proportional

This PR fixes #73879

Screen Shot 2020-12-15 at 8 23 08 AM

In accordance with this comment, incorrectly assigned proportional fonts in the terminal editor are reassigned to monospace by default.

@meganrogge
Copy link
Contributor

We can't set this for the user. For example, if using autosave and typing into settings.json, this would replace whatever you're typing with monospace. Where we use the font family value, we can add , monospace, which would fall back to a monospace font if the font is invalid. I don't think we should try to change it if someone has set a proportional font.

@meganrogge meganrogge closed this Feb 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal default font not useful if editor font is proportional
3 participants