Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git commit using '--signoff' #10410

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Git commit using '--signoff' #10410

merged 2 commits into from
Aug 12, 2016

Conversation

FabianLauer
Copy link

This PR addresses issue #7010. It adds support for committing with the --signoff flag enabled.

Instead of using a checkbox under the commit message input as suggested by @FrenchBen in the original issue, I added 2 actions to the context menu since signed off commits are fairly rare.

vscode-git-signoff-actions

Fabian Lauer added 2 commits August 10, 2016 23:13
This adds 2 actions to the context menu in the git changes view: 'Commit Staged (Signed Off)' and 'Commit All (Signed Off)'.
@msftclas
Copy link

Hi @FabianLauer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@FabianLauer, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@joaomoreno joaomoreno added this to the August 2016 milestone Aug 11, 2016
@joaomoreno joaomoreno merged commit e12293b into microsoft:master Aug 12, 2016
@joaomoreno
Copy link
Member

Thanks!

@joaomoreno joaomoreno mentioned this pull request Aug 12, 2016
@FabianLauer
Copy link
Author

Awesome, thanks! 😃
I hope I didn't cause you more work than the PR saved, looks like you made quite a few changes in these files afterwards 😳

@joaomoreno
Copy link
Member

No no, thank you! It was pretty great already, I simply did small refactorings. Most importantly, I made a protected abstract commit() on the BaseCommitAction, which lets us reuse most of the code between all those actions. 👍

@FabianLauer
Copy link
Author

Great, thanks for the insight, very helpful 😃

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants